Skip to content

chore: bump pnpm version 🍷 #7801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: bump pnpm version 🍷 #7801

wants to merge 4 commits into from

Conversation

gioboa
Copy link
Member

@gioboa gioboa commented Aug 8, 2025

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@gioboa gioboa requested a review from a team as a code owner August 8, 2025 15:16
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2e691a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

wmertens
wmertens reviewed Aug 13, 2025
View reviewed changes
package.json
@@ -179,7 +179,7 @@
"yarn": "please-use-pnpm",
"pnpm": ">=9.0.5"
},
"packageManager": "pnpm@9.15.5",
"packageManager": "pnpm@10.14.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this require allowing builds? Like in https://github.com/orgs/pnpm/discussions/9109 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you need to run the pnpm approve-builds @gioboa. This might be tricky with cli stuff. I'm having issues in qwik-ui :(

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 14, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 584d52f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens left review comments

@maiieul maiieul maiieul left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gioboa @wmertens @maiieul